Skip to content

Commit

Permalink
[mypyc] Fix 3.12 issue with pickling of instances with __dict__ (#15574)
Browse files Browse the repository at this point in the history
This fixes the testPickling test case in
mypyc/test-data/run-classes.test on Python 3.12.

Handle another case that was missed in #15471. On 3.12 we rely on
Py_TPFLAGS_MANAGED_DICT and shouldn't define an explicit `__dict__`
member.

Work on mypyc/mypyc#995.
  • Loading branch information
JukkaL authored Jul 3, 2023
1 parent a759c49 commit 4df2215
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mypyc/codegen/emitclass.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def emit_line() -> None:
# that isn't what we want.

# XXX: there is no reason for the __weakref__ stuff to be mixed up with __dict__
if cl.has_dict:
if cl.has_dict and not has_managed_dict(cl, emitter):
# __dict__ lives right after the struct and __weakref__ lives right after that
# TODO: They should get members in the struct instead of doing this nonsense.
weak_offset = f"{base_size} + sizeof(PyObject *)"
Expand Down

0 comments on commit 4df2215

Please sign in to comment.