Skip to content

Commit

Permalink
[mypyc] Fix self-compilation on Python 3.12 (#15582)
Browse files Browse the repository at this point in the history
  • Loading branch information
JukkaL committed Jul 3, 2023
1 parent e86f097 commit 781dc8f
Showing 1 changed file with 24 additions and 14 deletions.
38 changes: 24 additions & 14 deletions mypyc/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,23 +40,31 @@
from mypyc.namegen import exported_name
from mypyc.options import CompilerOptions

if TYPE_CHECKING:
from distutils.core import Extension as _distutils_Extension
from typing_extensions import TypeAlias
if sys.version_info < (3, 12):
if TYPE_CHECKING:
from distutils.core import Extension as _distutils_Extension
from typing_extensions import TypeAlias

from setuptools import Extension as _setuptools_Extension
from setuptools import Extension as _setuptools_Extension

Extension: TypeAlias = Union[_setuptools_Extension, _distutils_Extension]
Extension: TypeAlias = Union[_setuptools_Extension, _distutils_Extension]


try:
# Import setuptools so that it monkey-patch overrides distutils
try:
# Import setuptools so that it monkey-patch overrides distutils
import setuptools
except ImportError:
pass
from distutils import ccompiler, sysconfig
else:
import setuptools
except ImportError:
if sys.version_info >= (3, 12):
# Raise on Python 3.12, since distutils will go away forever
raise
from distutils import ccompiler, sysconfig
from setuptools import Extension
from setuptools._distutils import (
ccompiler as _ccompiler, # type: ignore[attr-defined]
sysconfig as _sysconfig, # type: ignore[attr-defined]
)

ccompiler = _ccompiler
sysconfig = _sysconfig


def get_extension() -> type[Extension]:
Expand All @@ -65,11 +73,13 @@ def get_extension() -> type[Extension]:
use_setuptools = "setuptools" in sys.modules
extension_class: type[Extension]

if not use_setuptools:
if sys.version_info < (3, 12) and not use_setuptools:
import distutils.core

extension_class = distutils.core.Extension
else:
if not use_setuptools:
sys.exit("error: setuptools not installed")
extension_class = setuptools.Extension

return extension_class
Expand Down

0 comments on commit 781dc8f

Please sign in to comment.