-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Switch from flake8
to ruff
#15362
Merged
Merged
Commits on Jun 3, 2023
-
To quote Ruff's README: "An extremely fast Python linter, written in Rust". In my testing Ruff takes 200ms to lint the entire codebase whereas flake8 takes about 5.5 seconds (27x slower). Running `pre-commit run -a` only takes about 2.3 seconds now, which should make local dev work a bit faster (assuming you run linters regularly). Ruff includes a lot of rules out of the box, including all the (important) rules from `flake8`, `flake8-bugbear`, `flake8-noqa`, and many more. Having all these built-in rules makes it much easier to incrementally improve the codebase without having to install tons of flake8 plugins. I made sure that the configs matched as close as I could get them. Some minor rules like line indentation and such aren't in Ruff since they are always just disabled. Ruff also ignores everything in the `.gitignore` file, so that cleans up the exclude section. Lastly, the `test-data` section seemed to have its own `.flake8` config file, but it was disabled in the `setup.cfg` file. I migrated the config over, but it doesn't really matter because it is being ignored anyways. Is this intentional?
Configuration menu - View commit details
-
Copy full SHA for 0ee7349 - Browse repository at this point
Copy the full SHA 0ee7349View commit details
Commits on Jun 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for df7ed7a - Browse repository at this point
Copy the full SHA df7ed7aView commit details
Commits on Jun 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fde0bf5 - Browse repository at this point
Copy the full SHA fde0bf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26633c5 - Browse repository at this point
Copy the full SHA 26633c5View commit details
Commits on Jun 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7625983 - Browse repository at this point
Copy the full SHA 7625983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc7ce8 - Browse repository at this point
Copy the full SHA 6bc7ce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 580c503 - Browse repository at this point
Copy the full SHA 580c503View commit details
Commits on Jun 20, 2023
-
Co-authored-by: Alex Waygood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 925089f - Browse repository at this point
Copy the full SHA 925089fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.