Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict optional for pythoneval tests #15474

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Enable strict optional for pythoneval tests #15474

merged 3 commits into from
Jun 20, 2023

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jun 19, 2023

No description provided.

hauntsaninja
hauntsaninja reviewed Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for doing this!

I think several of the x = None # type: int can be replaced by x: int, especially when they're immediately reassigned

hauntsaninja
hauntsaninja approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit 15f210b into python:master Jun 20, 2023
@cdce8p cdce8p deleted the test-pythoneval-enable-strict-optional branch June 20, 2023 08:28
@cdce8p cdce8p mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @hauntsaninja