Support better __post_init__ method signature for dataclasses
#15503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @ikonst and @ilevkivskyi as recent reviewers :) |
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
reviewed
Jun 23, 2023
Co-authored-by: Ivan Levkivskyi <[email protected]>
|
Done, all review items are now addressed. Thanks a lot for the quick feedback! 👍 |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use a similar approach to #14849
First, we generate a private name to store in a metadata (with
-, so - no conflicts, ever).Next, we check override to be compatible: we take the currect signature and compare it to the ideal one we have.
Simple and it works :)
Closes #15498
Closes #9254