Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install tomli for Python>=3.11 #15504

Closed
wants to merge 1 commit into from
Closed

Do not install tomli for Python>=3.11 #15504

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

Now it is in sync with setup.py and pyproject.toml
Refs #15501

@sobolevn
Do not install tomli for Python>=3.11
6664ca1 
Now it is in sync with `setup.py` and `pyproject.toml`
@AlexWaygood
Copy link
Member

This breaks the self-check for developers who use Python 3.11 locally, I think

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 23, 2023 •
edited
Loading

This breaks the self-check for developers who use Python 3.11 locally, I think

It was specifically added in #14492. We need it because python_version is always set to 3.7 when running the self-check:

mypy/mypy_self_check.ini

Line 9 in a47279b

python_version = 3.7

But the 3.7 branches don't type-check if you haven't got tomli installed.

@sobolevn sobolevn closed this Jun 23, 2023
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @AlexWaygood