Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadTheDocs configuration files #15514

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Jun 24, 2023

ReadTheDocs will stop building projects without a configuration file in September. Let's migrate early. Not sure how to test this, frankly.

@hauntsaninja I'll need your help as I don't have admin access to the mypy RTD project. Once this is merged, you'll have to set this field for mypy.
image

(I can set this for mypyc myself.)

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's see how this goes!

@hauntsaninja hauntsaninja merged commit 9ad3f38 into python:master Jun 26, 2023
@hauntsaninja
Copy link
Collaborator

Set this for mypy on RTD:
Screenshot 2023-06-25 at 11 38 45 PM

@hauntsaninja
Copy link
Collaborator

Thanks for being on top of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants