Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-manifest action #15531

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix check-manifest action #15531

merged 1 commit into from
Jun 27, 2023

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jun 27, 2023

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cdce8p
Copy link
Collaborator Author

cdce8p commented Jun 27, 2023

Test all passed 🎉

@ilevkivskyi ilevkivskyi merged commit 4d94271 into python:master Jun 27, 2023
@cdce8p cdce8p deleted the fix-sdist branch June 27, 2023 13:01
@hauntsaninja
Copy link
Collaborator

Thanks for fixing! Should this be a rule in MANIFEST.in?

@cdce8p
Copy link
Collaborator Author

cdce8p commented Jun 27, 2023

Should this be a rule in MANIFEST.in?

What part exactly? I don't think the .readthedocs.yaml files need to be included in the sdist. They aren't at the moment AFAICT. That's also why the check-manifest action failed. Not sure it's worth adding an additional (and unnecessary) exclude statement for it.

@hauntsaninja
Copy link
Collaborator

Oh I meant an exclude like so:

exclude .gitmodules CONTRIBUTING.md CREDITS ROADMAP.md tox.ini action.yml .editorconfig

This is what we do for other files.

Tbh, I'm not quite sure what the semantics of the tool.check-manifest section is. But setuptools won't look at it when making the sdist, which is why I asked the question

@hauntsaninja
Copy link
Collaborator

Just checked the sdist and it's not in there, so seems fine either way! Thanks again for vigilantly keeping wheels green :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants