Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pre-commit to using mypyc compiled Black wheels #15544

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

hauntsaninja
Copy link
Collaborator

Might as well support mypyc usage in the ecosystem :-)

Might as well support mypyc usage in the ecosystem :-)
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p
Copy link
Collaborator

cdce8p commented Jun 29, 2023

That is awesome! Just a suggestion, would it make sense to move the mirror repo the pre-commit org? Not sure if Anthony would want to do it, but they manage the mypy mirror already and black isn't just any small project.

@hauntsaninja
Copy link
Collaborator Author

Maybe? The setup is slightly different than the other mirror repos, so I didn't want to get into it. It meets my needs and Github Actions will keep it up to date. Not unprecedented either, ruff also just has their own mirror.

@hauntsaninja hauntsaninja merged commit 95dde9d into master Jun 29, 2023
@hauntsaninja hauntsaninja deleted the hauntsaninja-patch-1 branch June 29, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants