Enable strict optional for more test files (3) #15597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Jul 5, 2023
| @@ -1090,7 +1090,7 @@ optional2(10) | |||
| optional2('test') | |||
|
|
|||
| def optional3(x: Optional[List[Any]]): | |||
| assert not x | |||
| assert x | |||
There was a problem hiding this comment.
I didn't quite understand this one!
There was a problem hiding this comment.
Tbh I didn't either. assert not x doesn't make much sense here. I only excludes the non-empty list. With strict optional, that results in an error for the next line where
return x[0] # E: Value of type "Optional[List[Any]]" is not indexableTo keep the intention, the assert should probably be assert not x and x is not None but I wasn't sure this would be better than just assert x.
cdce8p
commented
Jul 6, 2023
| @@ -1090,7 +1090,7 @@ optional2(10) | |||
| optional2('test') | |||
|
|
|||
| def optional3(x: Optional[List[Any]]): | |||
| assert not x | |||
| assert x | |||
There was a problem hiding this comment.
Suggested change
| assert x | |
| assert not x and x is not None |
This would work as well, although as mentioned earlier, I'm not convinced it's better. Feel free to accept or dismiss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #15586