Enable strict optional for more test files (9) #15607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
test-data/unit/check-unions.test
Outdated
|
|
||
| reveal_type(u(C(), None)) # N: Revealed type is "__main__.C" | ||
| reveal_type(u(None, C())) # N: Revealed type is "__main__.C" | ||
| reveal_type(u(C(), None)) # N: Revealed type is "Union[None, __main__.C]" |
There was a problem hiding this comment.
Would it be better to keep this test non-strict-optional? Seems like it specifically tests that None isn't kept as part of the union.
test-data/unit/check-unions.test
Outdated
| @@ -277,15 +278,15 @@ T = TypeVar('T') | |||
| S = TypeVar('S') | |||
| def u(x: T, y: S) -> Union[S, T]: pass | |||
|
|
|||
| a = None # type: Any | |||
| a: Any | |||
|
|
|||
| # Base-class-Any and None, simplify | |||
There was a problem hiding this comment.
This comment no longer applies
There was a problem hiding this comment.
Thanks for the quick review!
I added --no-strict-optional here, similar to the one above. When we remove the flag at some point, we'll need to update all those test results anyway. For now it doesn't really matter tbh.
The goal is just to enable strict optional by default for test cases.
JelleZijlstra
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #15586
This will be the last one 🚀