Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubgen: unify C extension and pure python stub generators with object oriented design #15770

Merged
merged 12 commits into from
Oct 15, 2023
Merged

stubgen: unify C extension and pure python stub generators with object oriented design #15770

merged 12 commits into from
Oct 15, 2023

Commits on Oct 15, 2023

  1. [stubgen] Introduce an object-oriented design for C extension stub ge… 

    …neration
    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    5cdb7eb View commit details
    Browse the repository at this point in the history

  2. Do not filter __version__ module attribute: it is useful in practice.

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    e14f409 View commit details
    Browse the repository at this point in the history

  3. Code review updates

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    90874b4 View commit details
    Browse the repository at this point in the history

  4. More review fixes

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    f0a803d View commit details
    Browse the repository at this point in the history

  5. fix

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    54d113e View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @chadrik
    pre-commit-ci[bot] authored and chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    c74a4a0 View commit details
    Browse the repository at this point in the history

  7. Apply suggested change to stubgenc 

    isbuiltin is isinstance(object, types.BuiltinFunctionType), and type(ord) is BuiltinFunctionType, so these conditions are the same

Co-authored-by: Jelle Zijlstra <[email protected]>
    @chadrik @JelleZijlstra
    chadrik and JelleZijlstra committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9bef8d9 View commit details
    Browse the repository at this point in the history

  8. Review notes

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    a91d2c2 View commit details
    Browse the repository at this point in the history

  9. Add tests for __exit__ inference

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    7da58da View commit details
    Browse the repository at this point in the history

  10. Review notes

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    cae5ba2 View commit details
    Browse the repository at this point in the history

  11. Review notes

    @chadrik
    chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    b3a6540 View commit details
    Browse the repository at this point in the history

  12. Update docs/source/stubgen.rst

    @JelleZijlstra @chadrik
    JelleZijlstra authored and chadrik committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    03d01a4 View commit details
    Browse the repository at this point in the history