-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 1.9.0 #16978
Add changelog for 1.9.0 #16978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Glad to see you're back and healthy again!
CHANGELOG.md
Outdated
|
||
#### Breaking Changes | ||
|
||
Because the version of typeshed we use in mypy 1.9 doesn't support 3.7, neither does mypy 1.9. (Marc Mueller, PR [16900](https://github.com/python/mypy/pull/16900)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was your PR. I just backported it 😅
See: #16883
CHANGELOG.md
Outdated
* Apply TypeVar defaults to callables (PEP 696) (Marc Mueller, PR [16842](https://github.com/python/mypy/pull/16842)) | ||
* Use TypeVar defaults instead of Any when fixing TypeAlias types (PEP 696) (Marc Mueller, PR [16825](https://github.com/python/mypy/pull/16825)) | ||
* Use TypeVar defaults instead of Any when fixing instance types (PEP 696) (Marc Mueller, PR [16812](https://github.com/python/mypy/pull/16812)) | ||
* Consider TypeVarTuple to be invariant (Marc Mueller, PR [16759](https://github.com/python/mypy/pull/16759)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to move this one to the Miscellaneous Fixes
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a few suggestions
CHANGELOG.md
Outdated
* Stubtest will ignore private function/method parameters when they are missing from the stub. | ||
Private parameters names start with a single underscore and have a default | ||
(PR [16507](https://github.com/python/mypy/pull/16507)). | ||
* Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) | |
* Stubtest: ignore a new protocol dunder (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...This was my PR, Marc just cherry-picked it to the release-1.9 branch :)
CHANGELOG.md
Outdated
* Stubtest will ignore private function/method parameters when they are missing from the stub. | ||
Private parameters names start with a single underscore and have a default | ||
(PR [16507](https://github.com/python/mypy/pull/16507)). | ||
* Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) | |
* Stubtest: ignore a new protocol dunder (Alex Waygood, PR [16895](https://github.com/python/mypy/pull/16895)) |
This was also only a cherry-pick PR. Linked the correct one here.
CHANGELOG.md
Outdated
* Use TypeVar defaults instead of Any when fixing instance types (PEP 696) (Marc Mueller, PR [16812](https://github.com/python/mypy/pull/16812)) | ||
* Consider TypeVarTuple to be invariant (Marc Mueller, PR [16759](https://github.com/python/mypy/pull/16759)) | ||
|
||
#### Miscellaneous Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider combining Plugin Improvements
and Miscellaneous Fixes
and name it Type-checking Improvements
similar to the notes for release 1.8.
and maybe further up, above below the new typechecking features.
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll do some editing in a separate PR after merging this.
I did my best to sort them out in a way I thought was reasonable, but feel free to suggest improvements. I also removed a few that were linter version updates etc.