Improvements to descriptor __set__
#17170
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong error location when assignment errors is due to
__set__
. Presently, the error location appears on the right:e570aa1 will change the error location to be on the left:
Fixes Descriptors and ClassVars #14969
ClassVar
there is not specified with a type (an unannotatedClassVar
is equivalent toClassVar[Any]
).Any
, due to the potential creep of false negatives.