Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter reporting (i.e. don't highlight entire functions for certain errors) #17203

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shaperilio
Copy link

This pertains to #16746, and is a work in progress. Most likely, I'll work into #17006 instead. But since it's been a while, I wanted to have this here to comment on what I learned.

The goal is to avoid highlighting entire functions as the error for things like missing return statement, forgotten self, etc. I'm not sure we have an exhaustive list of the errors which do this, but perhaps we can find an approach where the entire function is never highlighted as an error.

Copy link
Contributor

github-actions bot commented May 1, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant