stubtest: changes for py313 #17261
Merged
stubtest: changes for py313 #17261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically it feels like we should be able to put the new dunders on `type` or something, but that wasn't enough to make false positives go away. But also we might not want to do that because it only applies to pure Python types
| @@ -634,6 +634,10 @@ def strip_prefix(s: str, prefix: str) -> str: | |||
| if strip_prefix(stub_arg.variable.name, "__") == runtime_arg.name: | |||
| return | |||
|
|
|||
| nonspecific_names = {"object", "args"} | |||
There was a problem hiding this comment.
Why do we need this block?
There was a problem hiding this comment.
stubtest attempts to make sure that positional-only arguments have vaguely the same names. This is because when I first wrote stubtest, I found cases of mismatched pos-only args in typeshed. Now having fixed all of those, the value of this check to typeshed is lower, but I'd still like to keep it.
Python 3.13 added text signatures for more callables, but these signatures are autogenerated, see https://github.com/python/cpython/pull/107794/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872R589
So now we no longer check the stub name is vaguely similar if the runtime name is "object"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it feels like we should be able to put the new dunders on
typeor something, but that wasn't enough to make false positives go away. But also we might not want to do that because it only applies to pure Python types