[PEP 695] Detect errors related to mixing old and new style features #17269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
stroxler
reviewed
May 21, 2024
| @@ -2421,6 +2421,10 @@ def annotation_in_unchecked_function(self, context: Context) -> None: | |||
| code=codes.ANNOTATION_UNCHECKED, | |||
| ) | |||
|
|
|||
| def type_parameters_should_be_declared(self, undeclared: list[str], context: Context) -> None: | |||
| names = ", ".join('"' + n + '"' for n in undeclared) | |||
| self.fail(f"All type parameters should be declared ({names} not declared)", context) | |||
There was a problem hiding this comment.
Should this error message more explicitly refer to "mixing" PEP 695 type variables vs legacy type variables?
I'm sure users would figure it out, but the legacy type variables are "declared" in some sense so it may confuse folks.
(Also I realize fine tuning the error messages can be done later, I just was briefly confused when skimming)
There was a problem hiding this comment.
I think this is fine for now; I couldn't think of a better wording immediately.
JelleZijlstra
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic[...]orProtocol[...]shouldn't be used with new-style syntax.Generic functions and classes using the new syntax shouldn't mix new-style and
old-style type parameters.
Work on #15238.