[PEP 695] Add more error checks and tests for error conditions #17339
Conversation
At least two are required, according do PEP 695. Work on #15238.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -330,3 +330,6 @@ def with_additional_msg(self, info: str) -> ErrorMessage: | |||
| NARROWED_TYPE_NOT_SUBTYPE: Final = ErrorMessage( | |||
| "Narrowed type {} is not a subtype of input type {}", codes.NARROWED_TYPE_NOT_SUBTYPE | |||
| ) | |||
| TYPE_VAR_TOO_FEW_CONSTRAINED_TYPES: Final = ErrorMessage( | |||
There was a problem hiding this comment.
Can this message be reused in semanal.py where a TypeVar cannot have only a single constraint message is used inline? This should help with discoverability of two TypeVar syntax variants constraints, because they share some common argument validation logic.
There was a problem hiding this comment.
I agree, if there are not too many tests to update, we should reuse the same message for both old and new style variables.
There was a problem hiding this comment.
I made the error messages consistent.
| @@ -271,7 +271,7 @@ def __hash__(self) -> int: | |||
| del error_codes[FILE.code] | |||
|
|
|||
| # This is a catch-all for remaining uncategorized errors. | |||
| MISC: Final = ErrorCode("misc", "Miscellaneous other checks", "General") | |||
| MISC: Final[ErrorCode] = ErrorCode("misc", "Miscellaneous other checks", "General") | |||
There was a problem hiding this comment.
Is this because we are not deferring top-levels, LOL?
There was a problem hiding this comment.
Possibly, though I didn't look into this in any detail. This is not the first instance of this issue in this module.
| @@ -330,3 +330,6 @@ def with_additional_msg(self, info: str) -> ErrorMessage: | |||
| NARROWED_TYPE_NOT_SUBTYPE: Final = ErrorMessage( | |||
| "Narrowed type {} is not a subtype of input type {}", codes.NARROWED_TYPE_NOT_SUBTYPE | |||
| ) | |||
| TYPE_VAR_TOO_FEW_CONSTRAINED_TYPES: Final = ErrorMessage( | |||
There was a problem hiding this comment.
I agree, if there are not too many tests to update, we should reuse the same message for both old and new style variables.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Detect invalid number of constrained types. At least two are required, according do PEP 695.
Add tests for other simple errors.
Work on #15238.