-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReadOnly
support for TypedDicts
#17644
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, I have few questions and suggestions.
I ended up with @ilevkivskyi thanks a lot for your review! You found several bugs that I've missed. Please, take a look again, once you have the time :) |
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Thanks a lot for this effort! |
Refs #17264
I will add docs in a separate PR.