Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[possibly-undefined] Fix loop misconceptions #17720

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[possibly-undefined] Fix loop misconceptions #17720

wants to merge 5 commits into from

Commits on Sep 10, 2024

  1. Refactor: Remove double negative to improve readability

    @NMertsch
    NMertsch committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3035fbe View commit details
    Browse the repository at this point in the history

  2. Refactor: Remove redundant if check

    @NMertsch
    NMertsch committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f78dfbb View commit details
    Browse the repository at this point in the history

  3. Fix: for loop index is only defined if body is executed

    @NMertsch
    NMertsch committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    02e65d0 View commit details
    Browse the repository at this point in the history

  4. Fix: for loop else body is executed if iterable was empty

    @NMertsch
    NMertsch committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    951b49a View commit details
    Browse the repository at this point in the history

  5. Fix: while loop else body is executed if first condition is False

    @NMertsch
    NMertsch committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    082ab1b View commit details
    Browse the repository at this point in the history