Enable checking for f strings #17732
Open
+83
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #17714
Support for f-string checking was already partially implemented. Consider this code:
Mypy ran these lines through the format checker. The call expressions look like this:
The difference is, that the actually static
"abc"
is converted to a "dynamic" spec.This MR attempts to enable type checking of f-strings by inlining these "semi dynamic" specs.
Open Questions:
pytest mypy/test/testcheck.py::TypeCheckSuite::check-string-format.test
. It never finds any errors even when it should clearly failChecklist