-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Make change-log visible in mypy documentation #17742
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5af7e30
Added myst-parser to enable markdown in sphinx
quinn-sasha c380742
Added myst_parser into extensions
quinn-sasha 47100ed
docs: created changelog.md in docs to include mypy/CHANGELOG.md into …
quinn-sasha 09086db
docs: Added comment into changelog.md to explain about this file
quinn-sasha 1aa35bf
docs: added changelog entry to table of contents
quinn-sasha c0c4991
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fa7a68e
Merge branch 'master' into changelog_issue
hauntsaninja 27fa7aa
Suppress myst warnings for non-consecutive header level increases
quinn-sasha f80f08c
Merge remote-tracking branch 'origin/changelog_issue' into changelog_…
quinn-sasha 281d9cd
Converted H4(####) to H3(###) instead of suppressing 'Non-consecutive…
quinn-sasha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
sphinx>=5.1.0 | ||
furo>=2022.3.4 | ||
myst-parser>=4.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<!-- This file includes mypy/CHANGELOG.md into mypy documentation --> | ||
```{include} ../../CHANGELOG.md | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,6 +103,7 @@ Contents | |
error_code_list2 | ||
additional_features | ||
faq | ||
changelog | ||
|
||
.. toctree:: | ||
:hidden: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do this. Instead, decrease the indentation in
CHANGELOG.md
. Look at https://github.com/python/mypy/blob/72c413d/CHANGELOG.md?plain=1#L14 — it uses####
(H4) right after##
(H2). So MyST-Parser is correct to flag this. It's a real problem that needs to be fixed rather than ignored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should be auto-replaced across that entire file. Running
sed -i 's/^####/###/g' CHANGELOG.md
should do what's needed to correct the mistake.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your guide!