-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed spelling issues. #17774
Fixed spelling issues. #17774
Changes from 8 commits
5c33478
cc5a3ef
c84e2ef
b31c211
90e296f
7a2ecf9
b2c35f9
a74ae21
271dd04
e453262
d0be99c
5ff2211
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ def __init__( | |
self.functions = functions | ||
self.classes = classes | ||
self.final_names = final_names | ||
# Names of C statics used for Python 3.12 type variable objects. | ||
# Names of C statistics used for Python 3.12 type variable objects. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this refers to "C statics" as in "C static variables". That terminology is used elsewhere in mypyc (example), so I think this is written as intended There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing that out! I'll leave it as is since "statics" seems to be the correct terminology. |
||
# These are only visible in the module that defined them, so no need | ||
# to serialize. | ||
self.type_var_names = type_var_names | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this refers to "yield from" (https://docs.python.org/3/whatsnew/3.3.html#pep-380), so it's written as intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like "from" is the correct terminology as per PEP 380 (https://docs.python.org/3/whatsnew/3.3.html#pep-380), so the original phrasing is accurate. The update might not be necessary.