New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PEP 695] Fix covariance of frozen dataclasses #17783

Merged

JukkaL merged 1 commit into master from variance-dataclass

Sep 18, 2024

Collaborator

JukkaL commented Sep 18, 2024

Fix this conformance test:

@dataclass(frozen=True)
class ShouldBeCovariant4[T]:
    x: T

vo4_1: ShouldBeCovariant4[float] = ShouldBeCovariant4[int](1)  # OK
vo4_2: ShouldBeCovariant4[int] = ShouldBeCovariant4[float](1)  # E

Link:
https://github.com/python/typing/blob/main/conformance/tests/generics_variance_inference.py#L66


          [PEP 695] Fix covariance of frozen dataclasses

4a479dd

Fix this conformance test:
```
@DataClass(frozen=True)
class ShouldBeCovariant4[T]:
    x: T

vo4_1: ShouldBeCovariant4[float] = ShouldBeCovariant4[int](1)  # OK
vo4_2: ShouldBeCovariant4[int] = ShouldBeCovariant4[float](1)  # E
```
Link:
https://github.com/python/typing/blob/main/conformance/tests/generics_variance_inference.py#L66

Contributor

github-actions bot commented Sep 18, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

svalentin approved these changes

View reviewed changes

JukkaL merged commit 9d7a042 into master

19 checks passed

JukkaL deleted the variance-dataclass branch

September 18, 2024 13:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet