Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments without a default cannot follow attributes with one #17785

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Arguments without a default cannot follow attributes with one #17785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56bd7d7
`dataclasses` plugin fix: arguments without a default cannot follow a…
embecka Sep 19, 2024
263cfae
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mypy/plugins/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,9 @@ def collect_attributes(self) -> list[DataclassAttribute] | None:
"Attributes without a default cannot follow attributes with one", context
)

found_default = found_default or (attr.has_default and attr.is_in_init)
found_default = found_default or (
attr.has_default and attr.is_in_init and not attr.kw_only
)
if found_kw_sentinel and self._is_kw_only_type(attr.type):
context = cls
if attr.name in current_attr_names:
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/check-dataclasses.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ from dataclasses import dataclass, field, KW_ONLY
class Application:
_: KW_ONLY
name: str = 'Unnamed'
rating: int = field(kw_only=False) # E: Attributes without a default cannot follow attributes with one
rating: int = field(kw_only=False)

Application(name='name', rating=5)
Application() # E: Missing positional argument "name" in call to "Application"
Expand Down
Loading