Add initial support for new style TypeVar defaults (PEP 696) #17985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| class ClassTs2[*Ts = *tuple[int, ...]]: ... | ||
| [builtins fixtures/tuple.pyi] | ||
|
|
||
| [case testPEP695TypeParameterDefaultInvalid] |
There was a problem hiding this comment.
There are no invalid tests for functions, and I couldn't find code that would error for bad defaults on generic functions.
There was a problem hiding this comment.
Done in 5f8e69c with a small exception for when the TypeVar isn't used in the function signature. In that case the TypeVar isn't actually bound to the tvar_scope. Fixing that would probably require a bit more work. Left it as a TODO for now.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
Oct 19, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for TypeVar defaults using the new syntax. Similar to the old syntax, it doesn't fully work yet for ParamSpec, TypeVarTuple and recursive TypeVar defaults.
Refs: #14851