-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix approved stub ignore, remove normpath #18045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
search-path-fix
branch
from
October 25, 2024 20:24
ecf5391
to
d1a9d1e
Compare
hauntsaninja
force-pushed
the
search-path-fix
branch
from
October 25, 2024 20:27
d1a9d1e
to
146a600
Compare
Benchmark on an earlier version of this PR. Looks like 0.3s saving on long and 0.7s saving on openai
|
This comment has been minimized.
This comment has been minimized.
The primer is a true negative (i.e. types-pyOpenSSL is installed). You can see it get introduced when regressed here: #15347 (comment) |
Diff from mypy_primer, showing the effect of this PR on open source code: scrapy (https://github.com/scrapy/scrapy)
- scrapy/utils/ssl.py:5: error: Library stubs not installed for "OpenSSL._util" [import-untyped]
- scrapy/utils/ssl.py:5: note: Hint: "python3 -m pip install types-pyOpenSSL"
- scrapy/utils/ssl.py:5: note: (or run "mypy --install-types" to install all missing stub packages)
- scrapy/utils/ssl.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18038
This maybe should have been two PRs