Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict = True for mypy_bootstrap.ini #18076

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

sobolevn
Copy link
Member

We almost had all strict flags set anyway, so many it will just work.
If not, it would be easier to turn something off.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sobolevn sobolevn merged commit b59878e into master Oct 30, 2024
19 checks passed
@sobolevn sobolevn deleted the mypy-bootstrap-strict branch October 30, 2024 21:44
@sobolevn
Copy link
Member Author

Thanks for the quick review!

@davidhalter
Copy link

On a related note: Is it intentional that warn_unreachable is not used? I have recently realized that this is not turned on and it feels a bit strange. There are about 39 errors when running with --warn-unreachable (on mypy_self_check.ini) and it brings up a few questionable things like https://github.com/python/mypy/blob/master/mypy/test/testpep561.py#L180.

It is also questionable why --strict does not just enable --warn-unreachable. A lot of people probably think "I'm running --strict, there's nothing else important to enable". However that's an entirely different topic.

@sobolevn
Copy link
Member Author

We should add --warn-unereachable to --strict in 2.0
@davidhalter can you please open two new issues about these two topics?

@davidhalter
Copy link

@sobolevn Done, see the issues above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants