Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project metadata for PEP 639 #18821

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Update project metadata for PEP 639 #18821

merged 1 commit into from
Mar 28, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Mar 19, 2025

Setuptools v77 was released today which adds full support for PEP 639.
https://setuptools.pypa.io/en/latest/history.html#v77-0-0
https://peps.python.org/pep-0639/

The relevant project metadata changes

 ...
-License: MIT
+License-Expression: MIT
 ...
-Classifier: License :: OSI Approved :: MIT License
 ...
 License-File: LICENSE
+License-File: mypy/typeshed/LICENSE
 ...

@@ -30,12 +30,12 @@ features such as type inference, gradual typing, generics and union
types.
""", content-type = "text/x-rst"}
authors = [{name = "Jukka Lehtosalo", email = "[email protected]"}]
license = {text = "MIT"}
license = "MIT"
license-files = ["LICENSE", "mypy/typeshed/LICENSE"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should CREDITS be included here? Until now it wasn't / is even explicitly excluded in MANIFEST.in.
https://github.com/python/mypy/blob/master/CREDITS

exclude .gitmodules CONTRIBUTING.md CREDITS ROADMAP.md action.yml .editorconfig

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't treated the credits file as part of the license in the past. It has only been updated very occasionally.

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p cdce8p requested a review from hauntsaninja March 26, 2025 18:43
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Let's remember to check that all metadata is shown correctly on PyPI after the next release.

@@ -30,12 +30,12 @@ features such as type inference, gradual typing, generics and union
types.
""", content-type = "text/x-rst"}
authors = [{name = "Jukka Lehtosalo", email = "[email protected]"}]
license = {text = "MIT"}
license = "MIT"
license-files = ["LICENSE", "mypy/typeshed/LICENSE"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't treated the credits file as part of the license in the past. It has only been updated very occasionally.

@JukkaL JukkaL merged commit 836019a into python:master Mar 28, 2025
18 checks passed
@cdce8p cdce8p deleted the pep639 branch March 28, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants