Fix: Add permanent redirects for legacy sponsorship pages (Issue #2645) (#2944)

* Fix #2645: Add permanent redirects for legacy sponsorship pages

* Fix #2645: Add permanent redirects for legacy sponsorship pages

Address Copilot PR feedback: use url patterns and reverse for sponsors redirects

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Update pydotorg/urls.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix sponsorship-old redirect test to expect /psf/sponsorship/

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jacob Coffee <jacob@z7x.org>

Author: 3 people

pydotorg/tests/test_views.py

@@ -34,3 +34,20 @@ def test_download_index(self):
         self.assertContains(response, "Browse Python 3.6.0 Documentation")
         self.assertContains(response, "https://docs.python.org/3/whatsnew/3.6.html")
         self.assertContains(response, "What's new in Python 3.6")
+
+    def test_legacy_sponsor_redirects(self):
+        """Test that old sponsorship pages correctly redirect to modern active ones."""
+        redirect_cases = (
+            ("/psf/sponsorship-old/", "/psf/sponsorship/"),
+            ("/psf/forms/sponsor-application/", reverse("new_sponsorship_application")),
+        )
+
+        for source_path, target_url in redirect_cases:
+            with self.subTest(source_path=source_path, target_url=target_url):
+                response = self.client.get(source_path)
+                self.assertRedirects(
+                    response,
+                    target_url,
+                    status_code=301,
+                    fetch_redirect_response=False,
+                )

pydotorg/urls.py

@@ -5,7 +5,7 @@
 from django.contrib import admin
 from django.contrib.staticfiles.urls import staticfiles_urlpatterns
 from django.urls import include, path, re_path
-from django.views.generic.base import TemplateView
+from django.views.generic.base import RedirectView, TemplateView
 
 from apps.cms.views import custom_404
 from apps.downloads.views import ReleaseEditButton
@@ -35,6 +35,14 @@
     path("blogs/", include("apps.blogs.urls")),
     path("inner/", TemplateView.as_view(template_name="python/inner.html"), name="inner"),
     # other section landing pages
+    path(
+        "psf/sponsorship-old/",
+        RedirectView.as_view(url="/psf/sponsorship/", permanent=True),
+    ),
+    path(
+        "psf/forms/sponsor-application/",
+        RedirectView.as_view(pattern_name="new_sponsorship_application", permanent=True),
+    ),
     path("psf-landing/", TemplateView.as_view(template_name="psf/index.html"), name="psf-landing"),
     path("psf/sponsors/", TemplateView.as_view(template_name="psf/sponsors-list.html"), name="psf-sponsors"),
     path("docs-landing/", TemplateView.as_view(template_name="docs/index.html"), name="docs-landing"),