Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typing_extensions #10344

Merged
merged 12 commits into from
Jul 22, 2023
Merged

Update typing_extensions #10344

merged 12 commits into from
Jul 22, 2023

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra
Copy link
Member Author

Stubtest is unhappy because these names don't exist in the released version of typing-extensions yet. I think it's better to have them in typeshed already though, so that type checkers have more of a chance to pick up the new stubs in time for the next typing-extensions release.

Maybe we should install typing-extensions from git in the stubtest workflow.

@JelleZijlstra
Copy link
Member Author

Seems like I need to fight stubtest some more, will look into it later today.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Copy link
Member Author

Now it's only pytype that's complaining, but it seems to be dumping out the entire ast of typing: https://github.com/python/typeshed/actions/runs/5340691697/jobs/9680790454?pr=10344

@rchen152 could you take a look? This is trying to implement the recent typing-extensions change where we now re-export more of typing.

AlexWaygood
AlexWaygood approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the pytype errors are resolved!

@hauntsaninja
Copy link
Collaborator

Thanks! Excited for this to land

srittau
srittau reviewed Jun 22, 2023
View reviewed changes
requirements-tests.txt Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood linked an issue Jun 29, 2023 that may be closed by this pull request
Typing extensions stubs are out of date (was: Daily tests failed on Thu Jun 29 2023) #10383
Closed
AlexWaygood added a commit that referenced this pull request Jun 29, 2023
@AlexWaygood
Pin typing_extensions to 4.6.3
7944a2e 
Our CI is very red on `main` at the moment, due to the release of typing_extensions 4.6.3 (see #10383). #10344 is the fix for this, but that PR breaks pytype. For now, let's just pin to 4.6.3 to get CI green again.
@AlexWaygood AlexWaygood mentioned this pull request Jun 29, 2023
Merged
JelleZijlstra pushed a commit that referenced this pull request Jun 29, 2023
@AlexWaygood
Pin typing_extensions to 4.6.3 (#10385)
b6a4221 
Our CI is very red on `main` at the moment, due to the release of typing_extensions 4.6.3 (see #10383). #10344 is the fix for this, but that PR breaks pytype. For now, let's just pin to 4.6.3 to get CI green again.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@rchen152
Copy link
Collaborator

@rchen152 could you take a look? This is trying to implement the recent typing-extensions change where we now re-export more of typing.

I'll take a look sometime this week! Just got back from a three-week vacation, so I'm working my way through my backlog.

@rchen152
Copy link
Collaborator

Ok, turns out this is a pretty easy fix! pytype's copy of the typing stub was missing ForwardRef. I'll release a fixed version next week.

rchen152 added a commit to google/pytype that referenced this pull request Jul 17, 2023
@rchen152
Add ForwardRef definition to typing stub.
2a4f680 
Copied from typeshed. Fixes pytype test failure in
python/typeshed#10344.

PiperOrigin-RevId: 548546490
@rchen152
Copy link
Collaborator

I released pytype-2023.07.21, but it looks like typeshed can't update to it because of a dependency conflict (https://github.com/python/typeshed/actions/runs/5626188689/job/15246504135). I see that there's already a PR open in the pycln repo to fix this: hadialqattan/pycln#209.

@AlexWaygood
Copy link
Member

I released pytype-2023.07.21, but it looks like typeshed can't update to it because of a dependency conflict (https://github.com/python/typeshed/actions/runs/5626188689/job/15246504135). I see that there's already a PR open in the pycln repo to fix this: hadialqattan/pycln#209.

Yeah, I noticed this issue when working on #10492 yesterday :/ hopefully the pycln maintainer will be okay with widening the libcst pin

@hauntsaninja
Copy link
Collaborator

(Could we just drop pycln? I think we're already using ruff + I don't like using things that pin dependencies)

This was referenced Jul 22, 2023
Merged
Merged
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit f577c4c into python:main Jul 22, 2023
103 checks passed
@AlexWaygood
Copy link
Member

Thanks @JelleZijlstra and @rchen152 both!

@bzoracler bzoracler mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@srittau srittau srittau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing extensions stubs are out of date (was: Daily tests failed on Thu Jun 29 2023)
5 participants
@JelleZijlstra @hauntsaninja @rchen152 @AlexWaygood @srittau