Bump setuptools to 72.2.* #12461
Bump setuptools to 72.2.* #12461
Conversation
|
Closes: #12458 |
This comment has been minimized.
This comment has been minimized.
| @deprecated( | ||
| "The test command is disabled and references to it are deprecated. Please remove any references to `setuptools.command.test` in all supported versions of the affected package." | ||
| ) | ||
| class _test(Command): | ||
| description: ClassVar[str] | ||
| user_options: ClassVar[list[tuple[str, str, str]]] | ||
| test_suite: Incomplete | ||
| test_module: Incomplete | ||
| test_loader: Incomplete | ||
| test_runner: Incomplete | ||
| def initialize_options(self) -> None: ... | ||
| def finalize_options(self) -> None: ... | ||
| @NonDataProperty | ||
| def test_args(self) -> list[str]: ... | ||
| def with_project_on_sys_path(self, func) -> None: ... | ||
| def project_on_sys_path(self, include_dists=()): ... | ||
| @staticmethod | ||
| def paths_on_pythonpath(paths) -> None: ... | ||
| @staticmethod | ||
| def install_dists(dist): ... | ||
| def run(self) -> None: ... | ||
| def run_tests(self) -> None: ... | ||
|
|
||
| test = _test |
There was a problem hiding this comment.
This doesn't seem to propagate the static deprecation (at least not in pylance). Given it's a new private name anyway, I'd just mark test directly.
There was a problem hiding this comment.
The problem with that is that we'd have to ignore the stubtest errors and stubtest won't complain if the class is removed or we make an error.
There was a problem hiding this comment.
The problem with that is that we'd have to ignore the stubtest errors
Are you sure? I'm running stubtest on setuptools locally on your branch with this change:
@deprecated(
"""\
The test command is disabled and references to it are deprecated. \
Please remove any references to `setuptools.command.test` in all supported versions of the affected package.\
"""
)
class test(Command):
description: ClassVar[str]
user_options: ClassVar[list[tuple[str, str, str]]]
def initialize_options(self) -> None: ...
def finalize_options(self) -> None: ...
def run(self) -> None: ...And it's passing as-is. Even changing an attribute of test to be missing or incorrect is picked up by stubtest. Let's say I remove description:
error: setuptools.command.test.test.description is not present in stub
Stub: in file E:\Users\Avasam\Documents\Git\typeshed\stubs\setuptools\setuptools\command\test.pyi
MISSING
Runtime:
'stub for old test command (do not use)'
There was a problem hiding this comment.
@srittau Setuptools 73 has just been released. I'd like to sync the typeshed stubs to it as well.
If you still feel unsure about my suggestion, I can approve your PR as-is and make the suggestion separately.
Co-authored-by: Avasam <[email protected]>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Avasam <[email protected]>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Co-authored-by: Avasam <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
No description provided.