Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pyright to v1.1.380 #12643

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 12, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pyright ==1.1.379 -> ==1.1.380 age adoption passing confidence

Release Notes

RobertCraigie/pyright-python (pyright)

v1.1.380

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the bot: dependencies 🤖 Dependency file updates by renovate 🤖 label Sep 12, 2024
@srittau
Copy link
Collaborator

srittau commented Sep 12, 2024

This looks like a regression in pyright. Previously, the following line checked ok, implying that pyright assumed y to be DataclassInstance:

if dc.is_dataclass(y) and not isinstance(y, type):
assert_type(y, "DataclassInstance")

Now, pyright infers y to be DataclassInstance | type[DataclassInstance], although in my understanding the right side of the and condition should exclude type[DataclassInstance].

Cc @erictraut

@erictraut
Copy link
Contributor

@srittau, yes this has already been reported here.

@srittau srittau closed this Sep 12, 2024
Copy link
Contributor Author

renovate bot commented Sep 12, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (==1.1.380). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/pytype-and-pyright branch September 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies 🤖 Dependency file updates by renovate 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants