Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: weight parameter type for networkx.algorithms.shortest_paths #12663

Merged
merged 28 commits into from
Sep 17, 2024
Merged

fix: weight parameter type for networkx.algorithms.shortest_paths #12663

merged 28 commits into from
Sep 17, 2024

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #12628

Mr-Sunglasses and others added 17 commits June 24, 2024 05:14
@Mr-Sunglasses
fix: ArgParse's registry for the type keyword argument to add_argument
26c7170
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5289125
@Mr-Sunglasses
fix: linter errors
b4d5891
@Mr-Sunglasses
Merge branch 'main' of github.com:Mr-Sunglasses/typeshed
0dea29e
@Mr-Sunglasses
fix: linter errors
a493f55
@Mr-Sunglasses
fix: linter errors
dcdb183
@Mr-Sunglasses
fix: _ActionStr Alias
d21006f
@Mr-Sunglasses
Merge branch 'main' into main
152bcd5
@Mr-Sunglasses
Merge branch 'main' into main
9471307
@Mr-Sunglasses
fix: _ActionStr Alias
17f9c8f
@Mr-Sunglasses
Merge branch 'python:main' into main
b560d86
@Mr-Sunglasses
Merge remote-tracking branch 'upstream/main'
515dcad
@Mr-Sunglasses
Merge branch 'python:main' into main
fe97809
@Mr-Sunglasses
fix: weight parameter type for networkx.algorithms.shortest_paths
8b6cb63
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bc958e1
@Mr-Sunglasses
fix: weight parameter type for networkx.algorithms.shortest_paths
040aab8
@Mr-Sunglasses
Merge branch 'fix/12628' of github.com:Mr-Sunglasses/typeshed into fi…
382509e 
…x/12628
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the fairly complex Callable[[Any, Any, dict[str, Any]], float | None] expression, I'd prefer to see this defined as a type alias (e.g. _WeightFunction) and that used in arguments.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Mr-Sunglasses
Copy link
Contributor Author

Considering the fairly complex Callable[[Any, Any, dict[str, Any]], float | None] expression, I'd prefer to see this defined as a type alias (e.g. _WeightFunction) and that used in arguments.

Thanks @srittau , I've done all the requested changes.

@srittau srittau merged commit eb7df6d into python:main Sep 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly typed weight parameter of networkx shortest_paths algorithms
2 participants
@Mr-Sunglasses @srittau