Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openpyxl: fix Worksheet.values annotation #12674

Merged
merged 2 commits into from
Sep 17, 2024
Merged

openpyxl: fix Worksheet.values annotation #12674

merged 2 commits into from
Sep 17, 2024

Conversation

sashkent3
Copy link
Contributor

Fixes #12673

srittau
srittau requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit below. Also for future reference: We don't require issues for fairly straight-forward PRs if you plan to submit a PR.

stubs/openpyxl/openpyxl/worksheet/worksheet.pyi Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 0015ce8 into python:main Sep 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type annotation for openpyxl.worksheet.Worksheet.values
2 participants
@sashkent3 @srittau