improve type annotations in 'docutils.readers.pep' #13320
Draft
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
docutils.readers.pep
branch
from
efa54f1 to
19cecd5
Compare
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.readers.pep
branch
from
79542c1 to
af827f5
Compare
|
marking as draft. this should be merged after #13321 |
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.readers.pep
branch
from
5cd4468 to
adcf2a8
Compare
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.readers.pep
branch
from
adcf2a8 to
e32a4ee
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/transforms/i18n.py: note: In function "publish_msgstr":
+ sphinx/transforms/i18n.py:88:20: error: Incompatible return value type (got "Node", expected "Element") [return-value]
+ sphinx/io.py:38: error: Unused "type: ignore" comment [unused-ignore]
+ sphinx/io.py:38:24: error: Missing type parameters for generic type "Reader" [type-arg]
+ sphinx/io.py:38:24: note: Error code "type-arg" not covered by "type: ignore" comment
+ sphinx/io.py: note: In member "new_document" of class "SphinxBaseReader":
+ sphinx/io.py:82:46: error: "SphinxBaseReader" has no attribute "settings" [attr-defined]
+ sphinx/io.py: note: At top level:
+ sphinx/io.py:102: error: Unused "type: ignore" comment [unused-ignore]
+ sphinx/io.py: note: In member "read_source" of class "SphinxStandaloneReader":
+ sphinx/io.py:111:19: error: Item "None" of "Input[Any] | None" has no attribute "read" [union-attr]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.