Remove stub content/style section from CONTRIBUTING.md #13332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reminds me of an old PR by @srittau and reviewed by @JelleZijlstra that went unmerged https://github.com/python/typeshed/pull/7594/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/typing#1882 has added the stub content/style guidelines from
CONTRIBUTING.mdto the official typing documentation (https://typing.readthedocs.io/en/latest/guides/writing_stubs.html), so we can change the contributing guide to link to that directly.I added a special note re: omitting docstrings from typeshed, since the official docs only discusses tradeoffs (per Jelle's recommendation in python/typing#1880 (comment))