Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml: Add missing types for DocumentType's publicId and systemId #13343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/xml/dom/minidom.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@ class ReadOnlySequentialNamedNodeMap:
def length(self) -> int: ...

class Identified:
publicId: Incomplete
systemId: Incomplete
publicId: str | None
systemId: str | None

class DocumentType(Identified, Childless, Node):
nodeType: int
Expand Down Expand Up @@ -331,7 +331,7 @@ class Notation(Identified, Childless, Node):
class DOMImplementation(DOMImplementationLS):
def hasFeature(self, feature: str, version: str | None) -> bool: ...
def createDocument(self, namespaceURI: str | None, qualifiedName: str | None, doctype: DocumentType | None) -> Document: ...
def createDocumentType(self, qualifiedName: str | None, publicId: str, systemId: str) -> DocumentType: ...
def createDocumentType(self, qualifiedName: str | None, publicId: str | None, systemId: str | None) -> DocumentType: ...
def getInterface(self, feature: str) -> Self | None: ...

class ElementInfo:
Expand Down
Loading