Enable Ruff EXE (flake8-executable) #13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
dhruvmanila
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Dec 31, 2024
…ndows solution to executable bit (#15208) ## Summary I noticed that the solution mentioned in [shebang-not-executable (EXE001)](https://docs.astral.sh/ruff/rules/shebang-not-executable/#shebang-not-executable-exe001) was incorrect and likely copy-pasted from [shebang-missing-executable-file (EXE002)](https://docs.astral.sh/ruff/rules/shebang-missing-executable-file/#shebang-missing-executable-file-exe002) It was telling users to remove the executable bit from a non-executable file. Which does nothing. I also noticed locally that: - `chmod` wouldn't cause any file change to be noticed by git (`EXE` was also passing locally) under WSL - Using git allows anyone to fix this lint across OSes, for projects with CIs using git So I added a solution using [git update-index --chmod](https://git-scm.com/docs/git-update-index#Documentation/git-update-index.txt---chmod-x) ## Test Plan No test plan, doc changes only. As for running the chmod commands: python/typeshed#13346
AlexWaygood
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Is the change here that the stub file was previously marked as executable for some reason, and now it (correctly) no longer is, because the lint rule picked up that it didn't have a shebang?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13295
https://docs.astral.sh/ruff/rules/#flake8-executable-exe
Lints about
#!at the top of executable python files. (Doesn't affect Windows)