Fix test failure on Python 3.11.9/3.12.3/main #205
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added a commit
to regro-cf-autotick-bot/cytoolz-feedstock
that referenced
this pull request
Sep 25, 2024
Newer Python releases fixed a bug/limitation in functools.signature. Taken from pytoolz/cytoolz#205.
|
Thanks Colin! 🙏 Think this was fixed in PR: #206 |
|
Thanks @cjwatson and @jakirkham! @jakirkham is correct, this was fixed in #206, which also added a test. I'm going to close this PR since it's not needed anymore, but I really appreciate your effort (and I recognize your PR came before #206, so I appreciate your promptness too!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as pytoolz/toolz#578.