Add pad #340
Open
Add pad #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this one? It seems we like to have the non-sequence arguments first, but am a little unsure of how we want to do that given a fill value. The other default arguments can be made non-default arguments easily. |
|
Friendly nudge. 😉 |
|
I wonder if this is doable just with the existing functions? @jakirkham is this useful enough to you to also provide a cytoolz implementation (I find that this is a good test for acceptance). Also this would be the first time that this docstring style would be used within toolz. We may want to question this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to pad an iterable on either end by a constant padding value. Also allows for infinite padding if needed.