This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Thread the scaling type argument throughout fp8 #301
Open
drisspg
wants to merge
9
commits into
gh/drisspg/1/base
Choose a base branch
from
gh/drisspg/1/head
base: gh/drisspg/1/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9db7cdc - Browse repository at this point
Copy the full SHA 9db7cdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fcd497 - Browse repository at this point
Copy the full SHA 4fcd497View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7a67bb - Browse repository at this point
Copy the full SHA f7a67bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b5ab8 - Browse repository at this point
Copy the full SHA e9b5ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4c98c5 - Browse repository at this point
Copy the full SHA a4c98c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7184b - Browse repository at this point
Copy the full SHA 4e7184bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 381018d - Browse repository at this point
Copy the full SHA 381018dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8404bf6 - Browse repository at this point
Copy the full SHA 8404bf6View commit details
Commits on Jul 17, 2024
-
Update on "Thread the scaling type argument throughout fp8"
# Summary This PR adds a ScalingGranularity Enum, and threads it though the stack to all the places we call 'tensor_to_amax" and tensor_to_scale. - Currently hardcodes TensroWise.Scaling in Float8Linear, Float8DynamicLinear, Float8InferenceLinear. Asserts that granularity is TensorWise for now. - Added this as a property of WeightWithDynamicFloat8CastTensor, since we need to know a prior how do do the scaling for fp8 comms. ### Testing ``` Shell ============================================================================= test session starts ============================================================================= platform linux -- Python 3.12.4, pytest-7.4.0, pluggy-1.5.0 rootdir: /home/drisspg/meta/float8_experimental plugins: hypothesis-6.104.1 collected 9 items test/test_fsdp2/test_fsdp2_eager.py ......... [100%] ============================================================================= 9 passed in 30.77s ============================================================================== all tests successful ``` [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d763faf - Browse repository at this point
Copy the full SHA d763fafView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.