Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ufmt linter for pyproject #47

Closed
wants to merge 20 commits into from
Closed

Add ufmt linter for pyproject #47

wants to merge 20 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Nov 9, 2024

Add linter to make sure PR is consistent with internal arc lint.

To format the code, run the following in the repo directory:

ufmt format .

We also test 25 operators in our H100 CI. Note that many of the flash_attention backends do not work right now and we need to fix them.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 359dfb4.

@xuzhao9 xuzhao9 deleted the xz9/add-linter branch November 11, 2024 22:32
@FindHao
Copy link
Member

FindHao commented Nov 21, 2024

pip install ufmt ruff-api

to install depednecies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants