Skip to content

Commit

Permalink
upgrade modelopt (#3160)
Browse files Browse the repository at this point in the history
  • Loading branch information
lanluo-nvidia authored Sep 16, 2024
1 parent 5719928 commit dbc41ce
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dynamic = ["version"]

[project.optional-dependencies]
torchvision = ["torchvision >=0.20.dev,<0.21.0"]
quantization = ["nvidia-modelopt[all]>=0.15.1"]
quantization = ["nvidia-modelopt[deploy,hf,torch]~=0.17.0"]
monitoring-tools = ["rich >= 13.7.1"]
jupyter = ["rich[jupyter] >= 13.7.1"]

Expand Down
8 changes: 5 additions & 3 deletions tests/py/dynamo/models/test_models_export.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# type: ignore
import importlib
import platform
import unittest
from importlib import metadata

Expand Down Expand Up @@ -250,9 +251,10 @@ def calibrate_loop(model):


@unittest.skipIf(
not importlib.util.find_spec("modelopt")
or Version(metadata.version("nvidia-modelopt")) < Version("0.16.1"),
"modelopt 0.16.1 or later is required Int8 quantization is supported in modelopt since 0.16.1 or later",
platform.system() != "Linux"
or not importlib.util.find_spec("modelopt")
or Version(metadata.version("nvidia-modelopt")) < Version("0.17.0"),
"modelopt 0.17.0 or later is required, Int8 quantization is supported in modelopt since 0.17.0 or later for linux",
)
@pytest.mark.unit
def test_base_int8(ir):
Expand Down
3 changes: 1 addition & 2 deletions tests/py/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ pytest-xdist>=3.6.1
pyyaml
timm>=1.0.3
transformers==4.40.2
# TODO @lanlao-nvidia Renable when modelopt can be install properly to run the tests
# "nvidia-modelopt[all]">=0.16.1,<0.17.0
nvidia-modelopt[deploy,hf,torch]~=0.17.0
--extra-index-url https://pypi.nvidia.com

0 comments on commit dbc41ce

Please sign in to comment.