feat: Add `_to_copy`, `operator.get` and `clone` ATen converters #2161

gs-olive · 2023-08-01T19:59:37Z

Description

Add ATen converters for key operators in the pipeline of multiple models
Add robust testing and patch issues in interpreter
Add evaluator and casting utilities to the converter utils

Fixes #2058

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

- Add ATen converters for key operators in the pipeline of multiple models - Add robust testing and patch issues in interpreter - Add evaluator and casting utilities to the converter utils

- torch compile precisions are currently not being reflected due to recent API changes. This update honors specified precisions

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths labels Aug 1, 2023

gs-olive requested a review from apbose August 1, 2023 19:59

gs-olive self-assigned this Aug 1, 2023

facebook-github-bot added the cla signed label Aug 1, 2023

gs-olive changed the title ~~feat: Add _to_copy, operator.get and clone~~ feat: Add _to_copy, operator.get and clone ATen converters Aug 1, 2023

github-actions bot added component: api [Python] Issues re: Python API component: tests Issues re: Tests labels Aug 1, 2023

github-actions bot requested a review from narendasan August 1, 2023 19:59

github-actions bot approved these changes Aug 1, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from a4dd045 to 393d4d2 Compare August 1, 2023 22:40

github-actions bot approved these changes Aug 1, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from 393d4d2 to 828fec0 Compare August 2, 2023 02:28

github-actions bot approved these changes Aug 2, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from 828fec0 to 98838f3 Compare August 2, 2023 16:21

github-actions bot approved these changes Aug 2, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from 98838f3 to e331363 Compare August 2, 2023 17:18

github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Aug 2, 2023

github-actions bot approved these changes Aug 2, 2023

View reviewed changes

gs-olive mentioned this pull request Aug 8, 2023

Explore stable diffusion support in Torch-TRT #1545

Closed

gs-olive commented Aug 11, 2023

View reviewed changes

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Show resolved Hide resolved

gs-olive commented Aug 11, 2023

View reviewed changes

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Outdated Show resolved Hide resolved

github-actions bot approved these changes Aug 11, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from 132f132 to d44ac0a Compare August 12, 2023 00:35

github-actions bot approved these changes Aug 12, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from d44ac0a to 4283f43 Compare August 14, 2023 16:39

github-actions bot approved these changes Aug 14, 2023

View reviewed changes

gs-olive requested a review from apbose August 14, 2023 18:52

github-actions bot approved these changes Aug 14, 2023

View reviewed changes

gs-olive force-pushed the get_clone_copy_aten branch from 4283f43 to af7719c Compare August 15, 2023 23:34

github-actions bot approved these changes Aug 15, 2023

View reviewed changes

apbose approved these changes Aug 16, 2023

View reviewed changes

gs-olive added 3 commits August 17, 2023 09:43

feat: Add _to_copy, operator.get and clone

61e716e

- Add ATen converters for key operators in the pipeline of multiple models - Add robust testing and patch issues in interpreter - Add evaluator and casting utilities to the converter utils

fix: Add temporary workaround for precisions

31c1cfd

- torch compile precisions are currently not being reflected due to recent API changes. This update honors specified precisions

fix: Increase block size to reduce compile time BERT

26d1051

gs-olive force-pushed the get_clone_copy_aten branch from af7719c to fbc3a7e Compare August 17, 2023 16:54

fix: Add generic evaluator function

2e902db

gs-olive force-pushed the get_clone_copy_aten branch from fbc3a7e to 2e902db Compare August 17, 2023 16:55

github-actions bot approved these changes Aug 17, 2023

View reviewed changes

gs-olive merged commit 6a69c6a into main Aug 17, 2023
4 checks passed

gs-olive deleted the get_clone_copy_aten branch August 17, 2023 19:06

broken-dream mentioned this pull request Aug 5, 2024

❓ [Question] function torch._ops.aten.aten::_to_copy not currently supported with dynamic input shape #3060

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add `_to_copy`, `operator.get` and `clone` ATen converters #2161

feat: Add `_to_copy`, `operator.get` and `clone` ATen converters #2161

gs-olive commented Aug 1, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

feat: Add _to_copy, operator.get and clone ATen converters #2161

feat: Add _to_copy, operator.get and clone ATen converters #2161

Conversation

gs-olive commented Aug 1, 2023

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

feat: Add `_to_copy`, `operator.get` and `clone` ATen converters #2161

feat: Add `_to_copy`, `operator.get` and `clone` ATen converters #2161