Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make engine caching opt-in feature #3152

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: make engine caching opt-in feature #3152

merged 1 commit into from
Sep 11, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Sep 10, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Sep 10, 2024
@peri044
Copy link
Collaborator Author

peri044 commented Sep 10, 2024

This can be closed I think - #3131

@zewenli98
Copy link
Collaborator

It seems when users switch on make_refittable, it still causes the error if some nodes are unsupported.

@peri044
Copy link
Collaborator Author

peri044 commented Sep 11, 2024

@narendasan The check is already in main https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/_compiler.py#L239-L247

It seems when users switch on make_refittable, it still causes the error if some nodes are unsupported.

@zewenli98 I'll handle that in another PR

@peri044 peri044 merged commit a689a3b into main Sep 11, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants