Conversation
apbose
force-pushed
the
DLFW_changes_25.01_onwards
branch
from
6fe0782 to
496e39d
Compare
peri044
approved these changes
Mar 13, 2025
Collaborator
peri044
left a comment
peri044
left a comment
There was a problem hiding this comment.
LGTM. posted a minor suggestion
Comment on lines
+1
to
+9
| #if defined(__GNUC__) && !defined(__clang__) | ||
| #if __GNUC__ >= 13 | ||
| #include <cstdint> | ||
| #endif | ||
| #elif defined(__clang__) | ||
| #if __clang_major__ >= 13 | ||
| #include <cstdint> | ||
| #endif | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Consider changing to
// Include cstdint for GCC 13+ or Clang 13+
#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ >= 13)) || \
(defined(__clang__) && (__clang_major__ >= 13))
#include <cstdint>
#endif
narendasan
reviewed
Mar 13, 2025
| EPOCHS = 25 | ||
|
|
||
| SUPPORTED_PYTHON_VERSIONS = ["3.9", "3.10", "3.11", "3.12"] | ||
| SUPPORTED_PYTHON_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.12"] |
Collaborator
There was a problem hiding this comment.
IIRC we dont support py 3.7, 3.8 anymore
Collaborator
Author
There was a problem hiding this comment.
Ok I will remove them then
narendasan
reviewed
Mar 13, 2025
| import torch | ||
| import torch.nn as nn | ||
| import torch_tensorrt as torchtrt | ||
| import torch_tensorrt.ts.ptq as PTQ |
Collaborator
There was a problem hiding this comment.
This is fine to have but we should drop these tests from DLFW as this API is being deprecated
Collaborator
Author
There was a problem hiding this comment.
Yes they are dropped in DLFW
apbose
force-pushed
the
DLFW_changes_25.01_onwards
branch
from
afbeaba to
0039841
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/util/Exception.h b/tmp/changes.txt
index d5a856f..8f05056 100644
--- a/home/runner/work/TensorRT/TensorRT/core/util/Exception.h
+++ b/tmp/changes.txt
@@ -1,7 +1,6 @@
// Include cstdint for GCC 13+ or Clang 13+
-#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ >= 13)) || \
- (defined(__clang__) && (__clang_major__ >= 13))
- #include <cstdint>
+#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ >= 13)) || (defined(__clang__) && (__clang_major__ >= 13))
+#include <cstdint>
#endif
#pragma once
ERROR: Some files do not conform to style guidelines
apbose
force-pushed
the
DLFW_changes_25.01_onwards
branch
from
ea5229f to
7aea483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes for the NGC container release