-
Notifications
You must be signed in to change notification settings - Fork 690
Fix conv2d bias INT48 type hint removed by fusing placeholder nods #15257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15257
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 3 Unrelated FailuresAs of commit 7cdc650 with merge base 296e07f ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: none" |
Summary: Enable int16 for op permute Reviewed By: Ninja91 Differential Revision: D84948536
…15257) Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods Reviewed By: Ninja91 Differential Revision: D84948170
76b5cb1
to
7cdc650
Compare
common_persistent, | ||
) | ||
|
||
# TBD: Find a principled way to merge node.meta across all fused node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a problem for 'non-standard' meta keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to write a conv2d test which fails without this change, just to safeguard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods
Reviewed By: Ninja91
Differential Revision: D84948170