Skip to content

Conversation

3l1
Copy link
Contributor

@3l1 3l1 commented Oct 19, 2025

Summary: Fix conv2d bias INT48 type hint removed by fusing placeholder nods

Reviewed By: Ninja91

Differential Revision: D84948170

@3l1 3l1 requested a review from digantdesai as a code owner October 19, 2025 02:23
Copy link

pytorch-bot bot commented Oct 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15257

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 3 Unrelated Failures

As of commit 7cdc650 with merge base 296e07f (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2025
Copy link

meta-codesync bot commented Oct 19, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84948170.

@3l1
Copy link
Contributor Author

3l1 commented Oct 19, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Oct 19, 2025
3l1 added 2 commits October 18, 2025 19:25
Summary:

Enable int16 for op permute

Reviewed By: Ninja91

Differential Revision: D84948536
…15257)

Summary:

Fix conv2d bias INT48 type hint removed by fusing placeholder nods

Reviewed By: Ninja91

Differential Revision: D84948170
common_persistent,
)

# TBD: Find a principled way to merge node.meta across all fused node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a problem for 'non-standard' meta keys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to write a conv2d test which fails without this change, just to safeguard.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good debugging @3l1.

CC: @per as FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants