Add get_cond_while_submodules utility #15699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding while to get_control_flow_submodules seems risky, could have unintended side effects. The new function is similar to get_control_flow_submodules though, so refactor that to share logic. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ia2b1b477f510eecb3b38b864546218528a8d3d8e
Erik-Lundell
requested review from
JacobSzwejbka and
larryliu0820
as code owners
Erik-Lundell
added
module: exir
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15699
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit c5a7380 with merge base c8e9684 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
the
release notes: none
Contributor
|
What is the context for the change? |
Collaborator
Author
Our backend is planning to support cond and while, which means that there will be many places where we want to access all submodules coming from such ops. See for example #15381 and #15364 that prepare for cond support, but I want to change get_control_flow_submodules -> get_cond_while_submodules when adding while support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding while to get_control_flow_submodules seems risky, could have unintended side effects.
The new function is similar to get_control_flow_submodules though, so refactor that to share logic.
cc @JacobSzwejbka @angelayi @freddan80 @per @zingo @oscarandersson8218 @digantdesai