Skip to content

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Dec 17, 2025

Adds new checks to quantization annotation to not fuse conv+relu patterns when output_qspec is symmetric. Symmetric quantization would force the zero-point to be 0, and in order for us to fuse relu the zero-point must equal qmin. Also adds new tests to verify that it works.

cc @freddan80 @per @zingo @digantdesai

Adds new checks to quantization annotation to not fuse conv+relu
patterns when output_qspec is symmetric. Symmetric quantization would
force the zero-point to be 0, and in order for us to fuse relu the
zero-point must equal qmin. Also adds new tests to verify that it works.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I85d58bf04ef2e2878462ba7f99bf0916534e7309
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16286

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit d6b4cd5 with merge base cf8496a (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes ciflow/trunk labels Dec 17, 2025
@zingo
Copy link
Collaborator

zingo commented Dec 17, 2025

Got fail, retrigger failed test job to see if it's random

FAILED backends/arm/test/ops/test_sub.py::test_sub_tensor_tosa_INT_alpha[rand_4D_pi] - AssertionError: Output 0 does not match reference output.
Given atol: 0.001, rtol: 0.001.
Output tensor shape: torch.Size([1, 10, 20, 30]), dtype: torch.float32
Difference: max: 0.24429035186767578, abs: 0.24429035186767578, mean abs error: 4.071505864461263e-05.
-- Model vs. Reference --
Numel: 6000, 6000
Median: 0.0, 0.0
Mean: 0.06314905179540316, 0.06310833673675854
Max: 32.00203323364258, 32.00203323364258
Min: -30.292001724243164, -30.292001724243164

@zingo
Copy link
Collaborator

zingo commented Dec 17, 2025

it worked, other fails are unrelated

@zingo zingo merged commit 257da59 into pytorch:main Dec 17, 2025
290 of 293 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants